search

microsoft / MIEngine

The Visual Studio MI Debug Engine ("MIEngine") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb and lldb.
MIT License
818 stars 218 forks source link

MIEngine: Array evaluation and address check #1427

Closed intel-rganesh closed 12 months ago

intel-rganesh commented 1 year ago

Issue description & fix:

Issue 1 When the address is not an AD7Memory address, we get a null reference exception while assigning puCodeLocationId. image

Fix The fix is to add a null reference check for this condition.

Issue 2 We would like to evaluate array addresses in Memory View. This was not possible without evaluating without an address operator. image

Fix For variable information value that looks like [], re-evaluate with address operator. image image

With this change we can evaluate an array address. image

Signed-off-by: intel-rganesh rakesh.ganesh@intel.com

gregg-miskelly commented 12 months ago

@WardenGnaw have you already investigated what is going on with:

D:\a\MIEngine\MIEngine\obj\Release\SSHDebugPS\UI\ContainerPickerDialogWindow.g.cs(50,18): error CS1504: Source file 'UI\ContainerPickerDialogWindow.xaml' could not be opened -- Could not find file. [D:\a\MIEngine\MIEngine\src\SSHDebugPS\SSHDebugPS_cba2tvoo_wpftmp.csproj]
gregg-miskelly commented 12 months ago

I see. This is what you fixed with https://github.com/microsoft/MIEngine/pull/1425. Any reason not to merge that?

WardenGnaw commented 12 months ago

I see. This is what you fixed with #1425. Any reason not to merge that?

Nope. That PR just got forgotten over the Thanksgiving holidays.