microsoft / ML-For-Beginners

12 weeks, 26 lessons, 52 quizzes, classic Machine Learning for all
https://microsoft.github.io/ML-For-Beginners/
MIT License
68.98k stars 14.24k forks source link

Update README.md code to correct data frame #656

Closed asilich123 closed 1 year ago

asilich123 commented 1 year ago

Readme sample code is referring to a previously used data frame simply named pumpkins. pumpkins data frame was renamed to new_pumpkins prior to this sample code. Updated sample code to reflect the change.

carlotta94c commented 1 year ago

Readme sample code is referring to a previously used data frame simply named pumpkins. pumpkins data frame was renamed to new_pumpkins prior to this sample code. Updated sample code to reflect the change.

Hi @asilich123, thanks for your PR! The code is referring to the original dataset, not the one resulting from column filtering, that's why it refers to pumpkins vs new_pumpkins. In fact, the description before that code chunk says 'Digging into the original data' and it suggests to 'Add a filter at the top of the file, under the initial .csv import'. Have a look at the solution notebook to see the final code. image