microsoft / ML-For-Beginners

12 weeks, 26 lessons, 52 quizzes, classic Machine Learning for all
https://microsoft.github.io/ML-For-Beginners/
MIT License
68.57k stars 14.11k forks source link

fix clustering lesson code sample issue #699

Closed cutePanda123 closed 5 months ago

cutePanda123 commented 8 months ago

In the 1-Visualize lesson of 5-Clustering group, the example code has a runtime error: the corr() method only works for numeric data, but the dataset has string data. It will trigger runtime error (like the below screenshot).

In this PR, I added a parameter to the corr() method to only apply the logic on numeric data and it fixed the issue.

image
github-actions[bot] commented 6 months ago

This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date.