search

microsoft / ML-For-Beginners

12 weeks, 26 lessons, 52 quizzes, classic Machine Learning for all
https://microsoft.github.io/ML-For-Beginners/
MIT License
68.57k stars 14.11k forks source link

Fix multiple function calls in Chapter 5 #739

Closed mfruhner closed 2 months ago

mfruhner commented 2 months ago

Hello,

there are currently two problems with the README of 5.1:

df.corr The default value of df.corr()'s numeric_only parameter changed to False in 2.0. Therefore the code in the notebook throws an error when executed. I set the parameter back to True, which fixes the notebook.

sns.FacetGrid The name of the size parameter has changed to height. I fixed that as well.

There is also a change in the handling of sns color palettes, where you now have to assign the hue parameter to x, but I did not include that change, yet. Let me know, if you would like me to add it.

In the README of 5.2, the sns.lineplot function does not accept 2 positional arguments (anymore). I named them x and y accordingly.

Best regards, Maik

mfruhner commented 2 months ago

@microsoft-github-policy-service agree company="University of Applied Sciences Osnabrueck"