search

microsoft / MLOS

MLOS is a project to enable autotuning for systems.
https://microsoft.github.io/MLOS
MIT License
136 stars 63 forks source link

Reenable Windows as a required CI check #768

Closed bpkroth closed 4 weeks ago

bpkroth commented 2 months ago

I've temporarily marked the Windows CI test as not required since there's something odd going on with it.

It's complaining about the same issue already addressed in #757, but somewhat intermittently.

ERROR mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_distr_test.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_viz/mlos_viz/tests - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_viz/mlos_viz/tests - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

However, it reports that the older version of numpy is correctly being installed.

There are at least two PRs that don't touch any Windows checks that are currently failing due to this so we'll just manually inspect and keep it as optional for the moment.

bpkroth commented 1 month ago

Mistakenly closed and referened the wrong one.

bpkroth commented 4 weeks ago

Done