microsoft / MLOpsPython

MLOps using Azure ML Services and Azure DevOps
MIT License
1.2k stars 1.09k forks source link

build pipeline for custom docker image fails #286

Closed benjaminbluhm closed 4 years ago

benjaminbluhm commented 4 years ago

Hi,

Needless to say this repo is super helpful!

I am running into an issue when creating a container build pipeline via Azure DevOps as described in docs/custom_container.md.

For testing purposes, I did not modify the Dockerfile and I only changed the environment name in environment_setup/docker-image-pipeline.yml. When I run the pipeline, I get the following error:

##[error]invalid argument "***/mlops/my_env:amlsdk-$(amlsdkversion)" for "-t, --tag" flag: invalid reference format
##[error]See 'docker build --help'.
##[error]The process '/usr/bin/docker' failed with exit code 125

It seems to me that $(amlsdkversion) does not resolve as expected. Is there anything I am doing wrong here?

j-so commented 4 years ago

You will need to set amlsdkversion and githubrelease as pipeline variables on execution time (or saved under Edit->Variables). These are used in the tags for your image.

image

This should get added to our docs.

benjaminbluhm commented 4 years ago

Thanks for clarifying this point. Adding this explanation to the docs would be good.