search

microsoft / MSBuildLocator

An API to locate MSBuild assemblies from an installed Visual Studio location. Use this to ensure that calling the MSBuild API will use the same toolset that a build from Visual Studio or msbuild.exe would.
Other
216 stars 83 forks source link

Indicates whether Roslyn is included #109

Closed Forgind closed 1 year ago

Forgind commented 3 years ago

Fixes #22

I didn't see an obvious way to determine whether the C# compiler was installed for the dotnet sdk, and I didn't want to replicate all the logic from VSLocationHelper for a command prompt. Maybe right?

Forgind commented 3 years ago

I could expose instance as a parameter as I have ContainsRoslynCompiler exposed here. Would you want the non-VS versions to return null for that?

YuliiaKovalova commented 1 year ago

Hi @rainersigwald and @Forgind,

Do we plan to work on this PR? Can we close it?

rainersigwald commented 1 year ago

I think we need to have a design for #22 before taking any implementation and would favor closing this.

Forgind commented 1 year ago

I think this is low enough priority that it doesn't warrant a serious design discussion. I'd personally prefer to just take this roughly as-is over closing it, but closing it makes more sense than talking about it for too long.