search

microsoft / MSBuildLocator

An API to locate MSBuild assemblies from an installed Visual Studio location. Use this to ensure that calling the MSBuild API will use the same toolset that a build from Visual Studio or msbuild.exe would.
Other
216 stars 83 forks source link

Analyzer #116

Closed Forgind closed 1 year ago

Forgind commented 3 years ago

image vs. image image image image

Still to do: drop into vsix.

Fixes #67

YuliiaKovalova commented 1 year ago

@Forgind, do you plan to finalize this PR?

Forgind commented 1 year ago

@Forgind, do you plan to finalize this PR?

I think this was a worthwhile project in getting people to not make this (rather confusing) mistake, but I didn't know how to actually ship the analyzer such that it would run on users' code. I think it might be worthwhile to ship this (and I can take Youssef1313's comments into account if so) if someone can offer a suggestion as to how to make the analyzer run for users?

rainersigwald commented 1 year ago

I think it is still a reasonable idea to have an analyzer that helps people use MSBuildLocator. This PR may be a good starting point for that, or it may be stale enough that it's easier to start over. Either way, I don't think we're planning to invest in an analyzer right now and I'd be ok closing this until we are.

YuliiaKovalova commented 1 year ago

Close with the comment: https://github.com/microsoft/MSBuildLocator/pull/116#issuecomment-1593615775