search

microsoft / MSBuildLocator

An API to locate MSBuild assemblies from an installed Visual Studio location. Use this to ensure that calling the MSBuild API will use the same toolset that a build from Visual Studio or msbuild.exe would.
Other
216 stars 83 forks source link

Prolong version check #147

Closed Forgind closed 2 years ago

Forgind commented 2 years ago

The change in #135 was supposed to be made unnecessary by https://github.com/dotnet/msbuild/pull/6890, but apparently my setup is the only one that has dotnet.exe under both the dotnet folder and the sdks folder, so it didn't work. xen2 fixed the problem in https://github.com/dotnet/msbuild/pull/7013, but that won't get in 'til 17.1, so we need to prolong the version check here.

Jonhi1393 commented 2 years ago

The change in #135 was supposed to be made unnecessary by https://github.com/dotnet/msbuild/pull/6890, but apparently my setup is the only one that has dotnet.exe under both the dotnet folder and the sdks folder, so it didn't work. xen2 fixed the problem in https://github.com/dotnet/msbuild/pull/7013, but that won't get in 'til 17.1, so we need to prolong the version check here.

Forgind commented 2 years ago

Hi @Jonhi1393,

You quoted my message but didn't add anything. What were you trying to say?