Bugfix: https://github.com/microsoft/MSBuildLocator/issues/176

microsoft / MSBuildLocator

An API to locate MSBuild assemblies from an installed Visual Studio location. Use this to ensure that calling the MSBuild API will use the same toolset that a build from Visual Studio or msbuild.exe would.

Other

219 stars 83 forks source link

Bugfix: https://github.com/microsoft/MSBuildLocator/issues/176 #177

Closed bernd5 closed 2 years ago

bernd5 commented 2 years ago

closes: #176

dotNetSdkPath may not end with / or \ - we can't use simple concat

ghost commented 2 years ago

All CLA requirements met.

bernd5 commented 2 years ago

Anything to change here?

bernd5 commented 2 years ago

Please review this PR

Forgind commented 2 years ago

Sorry I was a bit slow. This change and #178 seem roughly equivalent, and they're both correct as far as I can tell. That one is a more targeted change, but this one avoids allocating a dictionary unnecessarily. I just happened to see that first, so I merged it. This change looks good, too! Since I already merged that one, I'll close this, but thank you for your contribution!