search

microsoft / MSBuildLocator

An API to locate MSBuild assemblies from an installed Visual Studio location. Use this to ensure that calling the MSBuild API will use the same toolset that a build from Visual Studio or msbuild.exe would.
Other
220 stars 83 forks source link

Microsoft.Build.Locator package should be signed #71

Closed ryanbrandenburg closed 5 years ago

ryanbrandenburg commented 5 years ago

I've been writing a tool which uses Microsoft.Build.Locator, and now that it comes closer to time to ship it our pipeline complained because the dll isn't signed. I confirmed this by comparing the "properties" view of Microsoft.Build.Locator.dll vs a known signed dll and seeing that Locator was missing a "Digital Signatures" tab.

rainersigwald commented 5 years ago

@ryanbrandenburg Can you please try version 1.2.6 from our MyGet? If that meets your needs we will push it to nuget.org.

https://dotnet.myget.org/feed/msbuild/package/nuget/Microsoft.Build.Locator/1.2.6

ryanbrandenburg commented 5 years ago

I was able to put it through our pipeline and it appears to be signed, so we're good from that perspective. When can we get it updated on nuget?

rainersigwald commented 5 years ago

https://www.nuget.org/packages/Microsoft.Build.Locator/1.2.6 is now live