microsoft / MSBuildLocator

An API to locate MSBuild assemblies from an installed Visual Studio location. Use this to ensure that calling the MSBuild API will use the same toolset that a build from Visual Studio or msbuild.exe would.
Other
220 stars 83 forks source link

Add ProductId for Visual Studio instances #87

Closed jeffkl closed 4 years ago

jeffkl commented 4 years ago

Partially addresses https://github.com/microsoft/MSBuildLocator/issues/68 Helps me unblock https://github.com/microsoft/slngen/issues/121

jeffkl commented 4 years ago

Hmm, maybe I should just add a new class that wraps ISetupInstance and returns everything. And then our VisualStudioInstance object would have a VisualStudioInfo property that had it. Thoughts?

jeffkl commented 4 years ago

I'm going to abandon this PR and send a different revision that just plumbs through the whole VS instance object.