search

microsoft / MSBuildLocator

An API to locate MSBuild assemblies from an installed Visual Studio location. Use this to ensure that calling the MSBuild API will use the same toolset that a build from Visual Studio or msbuild.exe would.
Other
218 stars 83 forks source link

Failure to load NuGet SDKs in dotnet format #88

Closed rainersigwald closed 1 year ago

rainersigwald commented 4 years ago

@rainersigwald Rainer Sigwald FTE if you run the command below

dotnet tool install -g dotnet-format --version 4.0.121404 --add-source https://dotnet.myget.org/F/format/api/v3/index.json

and then run this command over this repo: https://github.com/dotnet/tye

dotnet-format -w tye.sln -v diag

you should get a bin log. Would be very curious to get a second opinion on what is happening here

from https://github.com/dotnet/format/issues/584#issuecomment-614135659

I reproduce with these instructions but haven't dug in.

JoeRobich commented 4 years ago

@sharwell Found that the NuGetSdkResolver wouldn't load unless we added a local dependency on Newtonsoft.Json. I'm not yet sure why the AssemblyLoader that we use couldn't resolve it from the SDK folder as it does other MSBuild dependencies.

YuliiaKovalova commented 1 year ago

@rainersigwald , it this issue still relevant? image

baronfel commented 1 year ago

dotnet format is shipped in the SDK these days, and I've successfully used it on many projects - I'm leaning towards this is probably not relevant anymore.

JoeRobich commented 1 year ago

Can confirm that we have not had recent reports of this issue.

YuliiaKovalova commented 1 year ago

Close as not relevant anymore. Thank you for your responses!