microsoft / MSBuildSdks

MSBuild project SDKs
MIT License
456 stars 81 forks source link

Microsoft.Build.Artifacts package should not depend on System.Threading.Tasks.Dataflow #490

Closed bording closed 1 year ago

bording commented 1 year ago

The Microsoft.Build.Artifacts package currently has a dependency on System.Threading.Tasks.Dataflow:

image

This package dependency means that a copy of System.Threading.Tasks.Dataflow.dll is copied into the output of projects using Microsoft.Build.Artifacts.

From what I can tell, this dependency is a mistake. While Microsoft.Build.Artifacts.dll does have a reference to System.Threading.Tasks.Dataflow.dll, the assembly is already shipped inside the package:

image

There should be no reason to have the package dependency. It would be great to get it removed!

jeffkl commented 1 year ago

Yeah this should be easy to fix, we need PrivateAssets=All here.