search

microsoft / MSBuildSdks

MSBuild project SDKs
MIT License
460 stars 82 forks source link

Set default SlnGenProjectName for Traversal projects #559

Open MattKotsenas opened 7 months ago

MattKotsenas commented 7 months ago

microsoft/slngen#557 added support for customizing the solution name using the MSBuild property <SlnGenProjectName>.

Today, if a user runs SlnGen with default properties, every VS window will unhelpfully be named "dirs". With this change, if a user hasn't set this property, this change sets it to the parent directory name, which is usually more descriptive. In some cases that may result in equally unhelpful names like "src", but that's no worse than today.

This may be considered a breaking change for SlnGen users in some scenarios. Specifically, if they were running slngen with no parameters set and then assuming the resulting solution would be named {dirs}.sln. In many cases, anyone that's writing scripts with slngen is also setting -o|--solutionfile, so they wouldn't be impacted, but I'm sure someone is relying on the name.

MattKotsenas commented 7 months ago

Open to thoughts / considerations on the benefits / risks here, but wanted to open a PR to start the conversation :)