search

microsoft / MSCloudLoginAssistant

PowerShell Module Handling Authentication to Cloud Services
https://www.powershellgallery.com/packages/MSCloudLoginAssistant/
MIT License
76 stars 52 forks source link

Fix security compliance #178

Closed willisdl closed 2 months ago

willisdl commented 3 months ago

Three changes to the code for connecting using service principal and thumbprint:

  1. $Global:MSCloudLoginConnectionProfile.OrganizationName was null and needs to have a value in order to connect
  2. Connection parameters should be pulling from $Global:MSCloudLoginConnectionProfile.SecurityComplianceCenter, not $Global:MSCloudLoginConnectionProfile.ExchangeOnline
  3. ShowProgress is not a valid parameter for Connect-IPPSSession

This change is Reviewable

willisdl commented 3 months ago

@microsoft-github-policy-service agree company="Microsoft"

FabienTschanz commented 2 months ago

@NikCharlebois Please review this PR as well. Thank you.