search

microsoft / MSIX-PackageSupportFramework

The Package Support Framework (PSF) is a kit for applying compatibility fixes to packaged desktop applications.
MIT License
115 stars 57 forks source link

PSF Scripting sample and Removing virtual enviorment. #106

Closed dhoehna closed 4 years ago

dhoehna commented 4 years ago

This PR has two changes.

  1. Adding the scripting sample.
  2. Removing the ability to not run powershell scripts outside of the app environment.

Change number 1 allows a user to test the scripting sample by building the solution. MSbuild will build, make, and install the sample app.

Change number 2 removes the ability to specify where you want the powershell scripts to run. All powershell scripts will run inside the app container. However, this means that PSF only works on RS2+.

jolonghi commented 4 years ago

��{

This file is messed up. I think something converted it to a bin format.

Refers to: tests/scenarios/ArchitectureTest/config.json:1 in 932e9c1. [](commit_id = 932e9c11131d833c6bf8f42427a408b779609849, deletion_comment = False)

jolonghi commented 4 years ago

��{

These json files are all messed up.

Refers to: tests/scenarios/CompositionTest/config.json:1 in 932e9c1. [](commit_id = 932e9c11131d833c6bf8f42427a408b779609849, deletion_comment = False)

jolonghi commented 4 years ago

There are still a number of standing comments I have made prior. Also, the config.json file examples are still all binary files. Is this intentional?

dhoehna commented 4 years ago

I'll resolve the other comments.

I don't know why the PR is making the configuration files binary. It is not intentionaly. They can be viewed as json outside of the PR.

I'll resolve the other comments.