Post350

[TimMangan]

This PR contains PSFLauncher the scripting changes to support arguments including the %MsixPackageRoot% pseudo variable so that the scripts can reference package files as arguments to the script.

It also has edge-case fixes for a few FileRedirectionFixup intercepts that improve application compatibility.

[TimMangan]

I'm not sure what the conflicts are all about. If necessary I'll cancel this PR and rebuild from a fresh fork, but hoping that isn't necessary.

[dhoehna]

Hey Tim. All the merge conflicts might be because this branch does not have all the changes from the past two PR's I accepted. You might want to either

1. Pull all changes from develop into this branch.
2. Make an entirly new branch that is current with develop and re-add your changes.

[TimMangan]

I'll rebalance, address other items above, and retest. Will post back when done.

[TimMangan]

Now that makes more sense!

Get Outlook for Androidhttps://aka.ms/ghei36

---

From: Darren Hoehna notifications@github.com Sent: Friday, March 13, 2020 1:31:45 PM To: microsoft/MSIX-PackageSupportFramework MSIX-PackageSupportFramework@noreply.github.com Cc: TIMOTHY MANGAN tmangan@tmurgent.com; Author author@noreply.github.com Subject: Re: [microsoft/MSIX-PackageSupportFramework] Post350 (#133)

@dhoehna commented on this pull request.

---

In PsfLauncher/PsfPowershellScriptRunner.hhttps://github.com/microsoft/MSIX-PackageSupportFramework/pull/133#discussion_r392372228:

• if (inString.length() > 4)
• {
• // Check for Powershell style references too
• if (inString[0] == L'' && inString[1] == L'\'' && inString[inString.length() - 2] == L'' && inString[inString.length() - 1] == L'\'')
• {
• return inString.substr(2, inString.length() - 4);
• }
• if (inString[0] == L'' && inString[1] == L'\"' && inString[inString.length() - 2] == L'' && inString[inString.length() - 1] == L'\"')
• {
• return inString.substr(2, inString.length() - 4);
• }
• }
• }
• return inString;
• }
• std::wstring EscapeFilename4PowerShell(std::filesystem::path inputPath)

Oops. I meant to replace 4 with For, not Four.

The varible name should be ExcapeFilenameForPowerShell.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/microsoft/MSIX-PackageSupportFramework/pull/133#discussion_r392372228, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEVBJFNSOBNPOWJPFOAWPU3RHJUYDANCNFSM4LF7NUMA.

[TimMangan]

Upon request, I have resynched to the develop branch and have a replacement PR for this one.