Trm 20200529 - Githubissues

microsoft / MSIX-PackageSupportFramework

The Package Support Framework (PSF) is a kit for applying compatibility fixes to packaged desktop applications.

MIT License

115 stars 57 forks source link

Trm 20200529 #145

Closed TimMangan closed 4 years ago

TimMangan commented 4 years ago

This PR contains the following:

Fix for PsfLauncher crash due to incorrect string processing on working directory=""
Fix for FRF for file accesses using "local device" syntax, i.e. "\\.\something". These are now ignored by the FRF.
Added a new fixup module called "RegLegacyFixups". Currently this supports only one type of registry fixup to solve issues with requests to open/create registry keys using permissions not allowed by MSIX, by changing the access permissions being requested.
Added small debugging improvements to the unit tests.

mattjreynolds commented 4 years ago

@TimMangan I've been looking into how to resolve some registry issues with packaging 3rd party applications. Looks like you already have a solution - perfect timing, I'll test this on my packages and let you know how I get on. Do you know if anyone has looked into possible fixup solutions for applications that want to write to HKLM? e.g redirecting into a location within HKCU

thanks, Matt

TimMangan commented 4 years ago

@mattjreynolds Not at this time. The PSF can't see the application hive directly, so we need either some Microsoft support or figure out where we want to redirect to.

If we have to do it ourselves, I am currently favoring adding a HKCU key to the package to redirect to; the PSF would redirect to there and then MSIX would redirect to wherever the heck it does that. But we'll just start small with this fix and then add to it with other fixup types within RegLegacy in the future.

dhoehna commented 4 years ago

@mattjreynolds That is an awesome idea actually. One issue I see with that is if the application opens a second executable that expects something to be in HKLM.

I don't know if it would be a problem. But I like the idea. I'll keep that in my notes as a possible PSF fixup.

dhoehna commented 4 years ago

��Microsoft (R) MakeAppx Tool

Please remove all the .txt files from the PR. #Resolved

Refers to: tests/scenarios/Appx/ArchitectureTest.appx.makeappx.txt:1 in 1378054. [](commit_id = 13780548a05d071a1d58dc4d27cb594bd5463206, deletion_comment = False)

dhoehna commented 4 years ago

@TimMangan Went over the PR. Added a few comments. Please address them when you can.

TimMangan commented 4 years ago

Removed logging txt files as well. All requests are processed.