microsoft / MSIX-PackageSupportFramework

The Package Support Framework (PSF) is a kit for applying compatibility fixes to packaged desktop applications.
MIT License
115 stars 57 forks source link

PSF Script with arguments including variablized username can fail if username has a space. #153

Closed TimMangan closed 1 year ago

TimMangan commented 4 years ago

The JSON entries for scripting allow for a single "argument list" to be enclosed in quotes.

I have seen an issue where one of the arguments was a variable but referenced the user name (profile path) and failed for a user with username that included a space because the command interpreted it as "argu ment list" rather than "'argu ment' 'list'".

This might suggest the need to update the Json structure for the argument, or improved guidance on creating the scripts.

aniketbanerji commented 2 years ago

Hi Tim,

Thank you for pointing this out. This will be resolved in the next release of PSF.

README will be updated to provide improved guidance for providing script arguments with space in config.json

npuvvada commented 1 year ago

This issue is resolved from release PSF release : version 1.0.220926.1. Please re-open the issue if it still does not help.