search

microsoft / MSIX-PackageSupportFramework

The Package Support Framework (PSF) is a kit for applying compatibility fixes to packaged desktop applications.
MIT License
115 stars 57 forks source link

EnvVarFixuup #154

Closed TimMangan closed 4 years ago

TimMangan commented 4 years ago

1) Created a new Psf intercept shim called "EnvVarFixup". This fixup allows the containerized application to have private environment variables in container processes. 2) Added new test cases in the test projects. 3) Cleaned up existing issues with other test cases.

TimMangan commented 4 years ago

Requested changes completed.

dhoehna commented 4 years ago

This PR has changes dating back to June 26th. Are those commits supposed to be in this PR?

TimMangan commented 4 years ago

This PR has changes dating back to June 26th. Are those commits supposed to be in this PR?

That is an artifact of how hard it is to work out of a fork when I must put the PR against anything other than the Master branch of the forkie. The entries in that list marked prior to August 20 are just an artifact of my getting my fork to be in sync with Microsoft/Develop. There are no file changes in the delta except for the new ones associated with this work.

This would be soooooo much easier if I were allowed to make branches under the Microsoft project instead of my own fork!

dhoehna commented 4 years ago

I will allow it this time. In the future please make sure all PR's have only relevant changes and no artifacts.

Once the PR is accepted please pull the changes from develop into your master branch. With that done, you can make a branch off of your master.

That means you'll need to do 2 PR's. One from your dev branch to your master and one from your master to MSIX-PackageSupportFramework/develop.

That way all changes will stay in their own branch and there should be no artifacts.

It is a bit tedious. I'll do some research and see that best way to handle this repository and the branching structure.