search

microsoft / MSIX-PackageSupportFramework

The Package Support Framework (PSF) is a kit for applying compatibility fixes to packaged desktop applications.
MIT License
115 stars 57 forks source link

DynamicLibrary with full path #168

Closed TimMangan closed 3 years ago

TimMangan commented 3 years ago

While applications usually load dlls using relative paths, sometimes they call with full path information.

DynamicLibraryFixup does not support the full path case where the location of the full path has moved. When written, it was incorrectly assumed the file redirection in the MSIX runtime would cover this case, but it does not.

This fixup should look at the filename only to determine if a internal dll file exists.

TimMangan commented 3 years ago

Currently working on a PR for this issue.

Solution is to strip the path off of the requested dll to be loaded before performing comparisons against the json list.

TimMangan commented 3 years ago

Resolved in PR #170 to Develop branch.