microsoft / MSLab

Azure Stack HCI, Windows 10 and Windows Server rapid lab deployment scripts
MIT License
1.2k stars 288 forks source link

Prereq fails at download diskspd #368

Closed hhulsman closed 4 years ago

hhulsman commented 4 years ago

Hi, wslab is awesome!

Now I got stuck with this:

Prereq.ps1 line 163 contains: $downloadurl = $webcontent.BaseResponse.ResponseUri.AbsoluteUri.Substring(0,$webcontent.BaseResponse.ResponseUri.AbsoluteUri.LastIndexOf('/'))+($webcontent.Links | where-object { $_.'data-url' -match '/Diskspd.*zip$' }|Select-Object -ExpandProperty "data-url")

After executing, $downloadurl contains just "https://github.com/microsoft". The where-object clause returns empty

jaromirk commented 4 years ago

@machv will fix it - it;s his regex ;D ... You can safely ignore it since it's just example tool that is added to tools disk (it just demonstrates you can have some tools there). Thank you for raising this issue and thank you for using WSLab!

jaromirk commented 4 years ago

hmm, looks like aka.ms/diskspd changed path to github... then it's broken. Let me harcode zip.

jaromirk commented 4 years ago

OK, fixed. Thank you!

hhulsman commented 4 years ago

Thanks!