jaromirk
commented
2 years ago @machv can we sign it?
Closed FlorianHeigl closed 1 year ago
jaromirk
commented
2 years ago @machv can we sign it?
machv
commented
2 years ago Work in progress :-) I have my own personal code signing certificate, but I would prefer to sign the scripts with a corporate one, I am investigating what would be the best way to proceed.
let's keep this one open.
FlorianHeigl
commented
2 years ago @machv bless you!
machv
commented
1 year ago Hello @FlorianHeigl, it took me little bit longer than I expected, but in the latest release (v22.09.1) all PowerShell scripts in the ZIP file are now signed with Microsoft code signing certificate.
Please keep in mind that any change to LabConfig.ps1 file will render its signature invalid and you'll need to sign LabConfig.ps1 with your own certificate as LabConfig.ps1 is dot-sourced in main MSLab scripts and needs to be signed as well. I put this info also to README.
FlorianHeigl
commented
1 year ago You guys deserve hero hats for this! Exemplary that you didn't chicken out but were helpful and worked with your orgs processes to do the right thing!
Jaromir Kaspar @.***> schrieb am Di., 29. Nov. 2022, 15:29:
Closed #513 https://github.com/microsoft/MSLab/issues/513 as completed.
— Reply to this email directly, view it on GitHub https://github.com/microsoft/MSLab/issues/513#event-7913161004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVSVGZV3H24PDLW5W3NKZDWKYHOBANCNFSM54FGWX2Q . You are receiving this because you were mentioned.Message ID: @.***>
Please, could you somehow sign the scripts? The whole powershell signing premise makes no sense if there's no way to run signed code from microsoft. Opensource or not, isn't there some way?