microsoft / MSLab

Azure Stack HCI, Windows 10 and Windows Server rapid lab deployment scripts
MIT License
1.18k stars 284 forks source link

DownloadLatestCUs not working for Windows 10 #520

Closed razza-guhl closed 1 year ago

razza-guhl commented 1 year ago

The script DownloadLatestCUs.ps1 does not work for OS Windows 10, no matter which release.

It seems the cmdlet "Get-MSCatalogUpdate" currently returns the ID for Windows 10 with 2x whitespaces between "Windows 10, version" instead of 1x whitespace:

ID="Windows 10, version 1903 and later" - (2x) current return ID="Windows 10, version 1903 and later" - (1x) string used in script

After manuall changed the ID with 2x whitespaces in the script on lines 46 to 49, download of latest CU worked again.

PS: Sorry, I would make a pull request if I knew how to properly do that.

jaromirk commented 1 year ago

Thank you! Will take a look!

jaromirk commented 1 year ago

Fixed! I also added Win11 and fixed 21h2. THX!