Efi special pool question

microsoft / MS_UEFI

Microsoft UEFI repo for open source contributions.

BSD 2-Clause "Simplified" License

48 stars 15 forks source link

Efi special pool question #1

Closed BrentHoltsclaw closed 7 years ago

BrentHoltsclaw commented 7 years ago

Within MS_UEFI/MdeModulePkg/Library/EfiSpecialPoolLib/SpecialPoolLib.c, is line 92 correct
if ((0x01 << PoolType) && PcdGet32(PcdSpecialPoolTypes)) { or should it be if ((0x01 << PoolType) & PcdGet32(PcdSpecialPoolTypes)) {

mikeytdisco commented 7 years ago

You are correct, it should be the bit-wise AND "&".

mikeytdisco commented 7 years ago

added a different implementation of EfiSpecialPool for standalone integration and additional bug fixes. See https://github.com/Microsoft/MS_UEFI/tree/share/EfiSpecialPoolV2

spbrogan commented 7 years ago

@BrentHoltsclaw - Your issue was fixed along with a few other issues. Thanks for taking a look and reporting the issue to us. TianoCore is also working on a similar feature and we eventually hope to replace our stand alone implementation with theirs which is embedded in the core memory management code. Thanks again.