search

microsoft / Microsoft-Fabric-workload-development-sample

Demonstrates how to implement a Microsoft Fabric workload in .net and typescript
Other
30 stars 16 forks source link

Fabric Workload Client npm package transitively depends on React #34

Closed q-benwillis closed 2 months ago

q-benwillis commented 4 months ago

It seems that the @ms-fabric/workload-client npm package has a dependency on "@fluentui/react-components" which has peer dependencies on React. We're not using React in our custom Workload, we're using Angular instead. It looks like the package only uses BrandVariants from "@fluentui/tokens" which doesnt have the any dependencies on React itself so the dependency on React seems unnecessary.

Is this dependency strictly necessary as it introduces quite a lot of bloat? Would it be possible to update the dependency for this package to avoid brining in the transitive dependency on React?

In the short term we'll just add these dependencies:

"react": "^17.0.2",
"react-dom": "^17.0.2",
anitamayorov commented 2 months ago

Hi @q-benwillis, Thanks for raising this - we are aware of this dependency and have a working task on that - no ETA yet.