microsoft / Microsoft-Fabric-workload-development-sample

Demonstrates how to implement a Microsoft Fabric workload in .net and typescript
Other
30 stars 16 forks source link

Deleting an item from Fabric's workspace view does not call the delete endpoint #87

Closed q-nicolechoi closed 4 weeks ago

q-nicolechoi commented 2 months ago

The "Delete" option from fabric's workspace view deletes the workload item but it does not call the delete item endpoint. Is there something we might be missing between the workspace UI and the endpoint?

image

tasdevani21 commented 2 months ago

We are seeing the same issue as well. That the delete call deletes the item but does not call the delete item endpoint.

tasdevani21 commented 2 months ago

Hi - Wanted to check in if there was any update on this issue?

atefsaw commented 2 months ago

Apologies for the delayed response, and thank you for bringing this to our attention. We are currently investigating the issue you mentioned. We will provide an update as soon as we have a resolution. Appreciate your patience!

q-nicolechoi commented 1 month ago

Hi, just noticed the same issue with the update item endpoint - the update call does not trigger the update item endpoint.

Also not sure if it is related - the update call gives an error

code: "NullReferenceException"
message: "Object reference not set to an instance of an object."

when I try to update the name or description of an item, but when I refresh the page the changes have actually been applied.

atefsaw commented 1 month ago

@tasdevani21 , @q-nicolechoi Are you still encountering this issue? Can you please specify if it is in dev mode or test mode? I verified this and I do see a call to the Delete endpoint. If this persists, please attach the RequestId from your network calls. Thanks!

q-nicolechoi commented 1 month ago

@atefsaw Hi, how do I check which mode we are in?

tasdevani21 commented 1 month ago

Hello @atefsaw - Yes specifically for us, it is the delete endpoint for us only. All other CRUD operations work fine. We are in the dev mode running everything locally.

Request Id: 5b801152-5daa-7ef4-d497-6502666ac049

image

It does delete the item properly from the workspace, however, it does not call the delete endpoint. We have also added a debugger to test this out and it never calls the delete endpoint. Please let us know if we can assist with any further debugging or if a sync call is better to sort it out. Thank you!

tasdevani21 commented 1 month ago

Hi @atefsaw - Any update on this and when it may be resolved?

atefsaw commented 1 month ago

Hi Tas, I tried to reproduce again and it does work for me. I've also looked in our logs (Based on the RequestId you sent) and I didn't see any failure there. Can you setup a logging middleware in your backend and see if there's any request to the delete endpoint?

atefsaw commented 1 month ago

@q-nicolechoi , do you still experience this issue? Regarding how can you check if you're in dev mode or not: are you running your backend locally? (on local host) If so, can you please attach a screenshot of the DevGateway console, after you initiate a CREATE operation, followed by a DELETE on the same item?

vinayslumel commented 1 month ago

I was also facing this issue earlier. From yesterday, I have observed that whenever we delete an item, We had a delete request to workload backend as well. But the authorization header is carrying an empty string for subjectToken, as part of the composite token.

tasdevani21 commented 1 month ago

@atefsaw - Thanks so much for the troubleshooting session. We can replicate the proper behavior for delete now and it is calling the backend properly in a repeated manner. Thank you for your time and we are unblocked now. We can close this issue from our end.

q-nicolechoi commented 1 month ago

@atefsaw yes I am running the backend locally. The update item endpoint (PATCH workspaces/{workspaceId}/items/{itemType}/{itemId}) is triggered now, but delete item endpoint (DELETE workspaces/{workspaceId}/items/{itemType}/{itemId}) is still not working as expected.

This is all I see in my DevGateway console. It does not print anything else when I initiate CREATE/DELETE item Image

Requestid: 88315075-2242-73c4-3743-362981fdc068 Image

atefsaw commented 1 month ago

@atefsaw yes I am running the backend locally. The update item endpoint (PATCH workspaces/{workspaceId}/items/{itemType}/{itemId}) is triggered now, but delete item endpoint (DELETE workspaces/{workspaceId}/items/{itemType}/{itemId}) is still not working as expected.

This is all I see in my DevGateway console. It does not print anything else when I initiate CREATE/DELETE item Image

Requestid: 88315075-2242-73c4-3743-362981fdc068 Image

Hi @q-nicolechoi ,

Based on the Requestid you attached, I do see that a DELETE was sent to your backend. Can you please try to add a middleware logger for the request or use an HTTP inspection tool to and watch for incoming requests and see if it's getting to your localhost?

In addition, I noticed that you're using an old version of the DevGateway. I'd suggest that you download and use the latest version, as it prints the incoming requests in the console - which should also help you see if the request has been sent to the DevGateway.

atefsaw commented 4 weeks ago

Closing this issue due to inactivity.

vinayslumel commented 4 weeks ago

I was also facing this issue earlier. From yesterday, I have observed that whenever we delete an item, We had a delete request to workload backend as well. But the authorization header is carrying an empty string for subjectToken, as part of the composite token.

This is still happening.