search

microsoft / Microsoft-MPI

Microsoft MPI
MIT License
244 stars 74 forks source link

Fix usage of invalid BOZ integer constants #44

Open albertziegenhagel opened 3 years ago

albertziegenhagel commented 3 years ago

gfortran >= 10.0 started to emit an error for BOZ integer constants in invalid locations. This change replaces the hexadecimal integer constants by regular ones, so that msmpi fortran bindings can be consumed by gfortran without the need to pass -fallow-invalid-boz.

Some amount of integer constants have already been replaced in #25.

edit: The conversions from the hexadecimal numbers to decimal numbers have been performed by a simple python script, so I hope there should not be any typos.

KineticTheory commented 3 years ago

👍 Thanks for putting this fix together. I'm seeing the same issues with gfortran.

scivision commented 3 years ago

Thank you. Currently there are a large volume of warnings emitted before this fix. Any way we can help expedite?

KineticTheory commented 3 years ago

@scivision @albertziegenhagel Do you know of a gfortran compiler flag or code pragma that will suppress this warning? I would like to silence this warning in my Appveyor CI. Thanks!