search

microsoft / Microsoft.IO.RecyclableMemoryStream

A library to provide pooling for .NET MemoryStream objects to improve application performance.
MIT License
1.98k stars 205 forks source link

Allow Partially Trusted Callers #108

Closed JanKallman closed 3 years ago

JanKallman commented 3 years ago

I have a pull request to implement this library into EPPlus... https://github.com/EPPlusSoftware/EPPlus/pull/207, which seems like a good idea. But we run into a problem as this library does not have the AllowPartiallyTrustedCallers attribute set, so EPPlus fails on .NET 4 or .NET 4.5. Is this intentionally left out for some reason or is it something that can be added?

benmwatson commented 3 years ago

Let me look into this in more detail. I think this could be easily done.

JanKallman commented 3 years ago

Thanks!

LIFEfreedom commented 3 years ago

I added the AllowPartiallyTrustedCallers attribute and all tests succeeded. Could not access method error not occurred

benmwatson commented 3 years ago

Would you like to submit a PR for this change?

LIFEfreedom commented 3 years ago

yes, i created PR for this change

LIFEfreedom commented 3 years ago

@benmwatson When can this change be observed in Nuget?

benmwatson commented 3 years ago

I will be publishing a new version today.

LIFEfreedom commented 3 years ago

Thanks!