[WIP] add lint: Allocating properties of Mesh should not be get in loop - Githubissues

microsoft / Microsoft.Unity.Analyzers

Roslyn analyzers for Unity game developers

MIT License

689 stars 74 forks source link

[WIP] add lint: Allocating properties of Mesh should not be get in loop #358

Open KisaragiEffective opened 1 month ago

KisaragiEffective commented 1 month ago

Fixes #52

Checklist

[x] I have read the Contribution Guide ;
[ ] There is an approved issue describing the change when contributing a new analyzer or suppressor ;
[x] I have added tests that prove my fix is effective or that my feature works ;
[ ] I have added necessary documentation (if appropriate) ;

Short description of what this resolves:

I'll make this PR will:

Address #52 (use mesh.vertexCount instead of mesh.vertices.Count)
about Binding "Allocating-properties":
1. Warn about
2. Move it to outer scope that does not surrounded by loop construct

However this is incomplete, and will be convered in later commits.

Changes proposed in this pull request:

[x] lint on getting "allocating-properties" in loop
- loop-dependency is not considered at the first commit
[ ] suggest mesh.vertexCount over mesh.vertices.Count