microsoft / Microsoft365DSC

Manages, configures, extracts and monitors Microsoft 365 tenant configurations
https://aka.ms/M365DSC
MIT License
1.44k stars 440 forks source link

Fix Properties of (Dynamic) Administrative Unit #4679

Open bartvermeersch opened 1 month ago

bartvermeersch commented 1 month ago

Pull Request (PR) description

Some properties of Dynamic Administrative Units have moved from within Additionalproperties to the root object level when performing Get-MgBetaDirectoryAdministrativeUnit

image

bartvermeersch commented 1 month ago

If I'm not mistaken in my analysis/findings the test also need to be updated?

https://github.com/microsoft/Microsoft365DSC/blob/473cd2ad6763cc8767cecd14c5596017eed6e0f2/Tests/Unit/Microsoft365DSC/Microsoft365DSC.AADAdministrativeUnit.Tests.ps1#L239-L242

NikCharlebois commented 3 weeks ago

Can we please update the branch with the latest code from DEV? It appears the unit tests are failing. Thanks

bartvermeersch commented 2 weeks ago

I think the unit tests were failing because they contain the same issue, but I want to have your confirmation.

membershipType, membershipRule, membershipRuleProcessingState are no longer children of "AdditionalProperties" but are direct children of the Administrative Unit object in beta graph.