search

microsoft / MixedReality-GraphicsTools-Unity

Graphics tools and components for developing Mixed Reality applications in Unity.
MIT License
182 stars 42 forks source link

Error in Acrylic Render Pass #196

Closed mgrubert-ml closed 6 months ago

mgrubert-ml commented 1 year ago

Describe the bug

Error due to AcrylicBlur shader in Unity 2023.1.x : Library\PackageCache\com.microsoft.mrtk.graphicstools.unity@cd59e032bb2e\Runtime\Experimental\Acrylic\Scripts\AcrylicBlurRenderPass.cs(189,13): error CS0619: 'ScriptableRenderPass.ConfigureTarget(RenderTargetIdentifier)' is obsolete: 'Use RTHandle for colorAttachment'

To reproduce

Create URP project in Unity 2023.1.14f1, then used MRTK tool to import Graphicstools and try to open project.

Your setup (please complete the following information)

Target platform (please complete the following information)

Cameron-Micka commented 1 year ago

Thanks @mgrubert-ml - we will take a look at this. We don't yet support Unity 2023. But will eventually and address this.

mgrubert-ml commented 1 year ago

@Cameron-Micka The Readme.MD says "The Graphics Tools package requires Unity 2021.3 and above." Might be helpful to put an upper bound there as well (Unity 2021.3 thru Unity 2022.x)

Cameron-Micka commented 1 year ago

Great idea @mgrubert-ml!

Torgo13 commented 1 year ago

I was able to update it to the new API by following this guide: rendertargethandle-is-obsolete-deprecated-in-favor-of-rthandle

Cameron-Micka commented 12 months ago

That's a wonderful resource, thanks @Torgo13. If you are able to make a PR with your changes, I would be happy to review it as well. 😊

Cameron-Micka commented 6 months ago

Hey @mgrubert-ml, this should be fixed now with v0.7.0 and above.