search

microsoft / MixedReality-GraphicsTools-Unity

Graphics tools and components for developing Mixed Reality applications in Unity.
MIT License
182 stars 41 forks source link

An additional Editor folder is created if one already exists but MeasureToolSettings.asset doesn't #95

Closed keveleigh closed 2 years ago

keveleigh commented 2 years ago

Describe the bug

If an Editor folder exists, the GetOrCreateSettings() path for MeasureToolSettings.asset will create a second one, but still place the new asset in the correct, original folder.

It seems to all come down to this line:

https://github.com/microsoft/MixedReality-GraphicsTools-Unity/blob/64ce5bbee6cc3872c0a00dc5db4cc05b56fae806/com.microsoft.mrtk.graphicstools.unity/Editor/MeasureTool/MeasureToolSettings.cs#L84

Unity seems to get confused by the trailing /...

Screenshots

image

Your setup (please complete the following information)

Cameron-Micka commented 2 years ago

@breezinstein do you have time to look at this one?

keveleigh commented 2 years ago

@breezinstein do you have time to look at this one?

Oops, I missed this and went ahead and opened #96 😬 Feel free to close/retarget/whatever!

Cameron-Micka commented 2 years ago

No, thank you, that was quick! @breezinstein I merged @keveleigh's PR. Feel free to update if need be.