microsoft / MixedReality-UXTools-Unreal

UX tools and components for developing Mixed Reality applications in UE4.
https://microsoft.github.io/MixedReality-UXTools-Unreal/
MIT License
316 stars 86 forks source link

Broken images on the github.io docs for Hand Interaction #3

Closed wiwei closed 4 years ago

wiwei commented 4 years ago

https://microsoft.github.io/MixedReality-UXTools-Unreal/version/public/0.8.x/Docs/HandInteraction.html

image

Consider using some of the CI scripts to prevent broken images from getting checked in: https://github.com/microsoft/MixedRealityToolkit-Unity/blob/mrtk_development/scripts/ci/validatedocs.ps1#L94

luis-valverde-ms commented 4 years ago

Thanks @wiwei ! @thalbern , is this something you could follow up on?

paco-ms commented 4 years ago

Note the image are correctly appearing if visualizing them through the .md files in github.com https://github.com/microsoft/MixedReality-UXTools-Unreal/blob/public/0.8.x/Docs/HandInteraction.md

paco-ms commented 4 years ago

It looks like case sensitivity issue.

The broken URL to the image is https://microsoft.github.io/MixedReality-UXTools-Unreal/version/public/0.8.x/Docs/Images/PokeInteraction.png.

The URL https://microsoft.github.io/MixedReality-UXTools-Unreal/version/public/0.8.x/Docs/Images/PokeInteraction.PNG works.

AB#469

luis-valverde-ms commented 4 years ago

Could it be that the image files in the doc website are stale? As far as I can tell both the image files and the references to them in the .md use .png now.

paco-ms commented 4 years ago

The stale image files are in the "gh_pages" branch and yes, those have the capitalized extension. Moving conversation to AB#469.

thalbern commented 4 years ago

fixed manually for old version https://microsoft.github.io/MixedReality-UXTools-Unreal/version/public/0.8.x/Docs/HandInteraction.html