microsoft / MixedReality-WebRTC

MixedReality-WebRTC is a collection of components to help mixed reality app developers integrate audio and video real-time communication into their application and improve their collaborative experience
https://microsoft.github.io/MixedReality-WebRTC/
MIT License
913 stars 283 forks source link

Unable to build from source code #615

Open slavabielkin opened 4 years ago

slavabielkin commented 4 years ago

I've been trying to build libraries from source (MixedReality-WebRTC, master branch). I've installed all of the pre-requisites, according to the documentation. When I run,

.\build.ps1 -BuildConfig Release -BuildArch ARM -BuildPlatform UWP

following error is occured:

c1xx : fatal error C1083: Cannot open source file: '........\xplatform\webrtc\sdk\windows\wrapper\impl_org_webRtc.cp p': No such file or directory [D:\mr-webrtc\external\webrtc-uwp-sdk\webrtc\windows\projects\msvc\Org.WebRtc.WrapperGlue .Universal\Org.WebRtc.WrapperGlue.vcxproj]

also followed by numeric "c1xx : fatal error C1083: Cannot open source file:...." errors.

I also tried to open Org.WebRtc.WrapperGlue .Universal\Org.WebRtc.WrapperGlue.vcxproj manually and recieved the same error. Also, if I try to open the file in VisualStudio, it tries to reference to following path: <D:\mr-webrtc\external\webrtc-uwp-sdk\webrtc\xplatform\webrtc\sdk\windows\wrapper\impl_org_webRtc.cpp>. but there is no "windows" directory in "\external\webrtc-uwp-sdk\webrtc\xplatform\webrtc\sdk" in repo: https://github.com/webrtc-uwp/webrtc/tree/c589db5d3ca4f199d4415f46b3b40eb8103093dd/sdk

fibann commented 4 years ago

That folder should be generated as a link by the WebRTC-UWP build process - there might be something failing earlier that prevents it from being generated. I'd suggest trying a clean build (run git submodule foreach --recursive 'git clean -xdf' from the repo root and rerun the script) and look for earlier errors in the logs. Make sure you are using Python 2.7.15+ (not 3.x).

slavabielkin commented 4 years ago

That folder should be generated as a link by the WebRTC-UWP build process - there might be something failing earlier that prevents it from being generated. I'd suggest trying a clean build (run git submodule foreach --recursive 'git clean -xdf' from the repo root and rerun the script) and look for earlier errors in the logs. Make sure you are using Python 2.7.15+ (not 3.x).

I executed git command you mentioned (see git.log). Python version is 2.7.18 I rerunned the script, and it showed same errors (see powerShell.log)

git.log powerShell.log

fibann commented 4 years ago

At the beginning of the log:

[WARNING          ] - [System         ] - checkTools                     - git is not installed. (system.py:154)
[WARNING          ] - [Utility        ] - returnOriginalFile             - D:\mr-webrtc\external\webrtc-uwp-sdk\scripts\..\.\webrtc\xplatform\webrtc\BUILD.gn or its backup doesn't exist. (utility.py:522)
[CRITICAL         ] - [System         ] - stopExecution                  - Script execution has failed (system.py:296)
[ERROR            ] - [System         ] - stopExecution                  - Git is missing! (system.py:297)
  File "..\..\external\webrtc-uwp-sdk\scripts\run.py", line 350, in <module>
    main()
  File "..\..\external\webrtc-uwp-sdk\scripts\run.py", line 280, in main
    System.stopExecution(errorCode)
  File "D:\mr-webrtc\external\webrtc-uwp-sdk\scripts\system.py", line 317, in stopExecution
    traceback.print_stack()

This seems to be an issue with your git installation. The part of the script that generates the symlinks is probably skipped due to this.

slavabielkin commented 4 years ago

Thanks for the tip. Git was not added to PATH variable. Also I needed to install Perl. Is specific version is requred for it too? I was able to proceed and now got stuck with: _File "D:/mr-webrtc/external/webrtc-uwp-sdk/webrtc/xplatform/webrtc/build/vs_toolchain.py", line 151, in DetectVisualStudioPath ' not found.') % (version_as_year)) "Exception: Visual Studio Version 2017 (from GYP_MSVSVERSION) not found." According to "Building from source->Prerequisites":

I tried to install VS 2017 in addition, but it did not help. I also have v142 toolsets installed for other projects. Power shell was "Run as administrator".

Please advise, Thank you