search

microsoft / MixedReality-WebRTC

MixedReality-WebRTC is a collection of components to help mixed reality app developers integrate audio and video real-time communication into their application and improve their collaborative experience
https://microsoft.github.io/MixedReality-WebRTC/
MIT License
909 stars 283 forks source link

Unity - WebRTC and WebRTC Samples package get imported into Packages #701

Open Mt-Perazim opened 3 years ago

Mt-Perazim commented 3 years ago

Describe the bug I tried to import the WebRTC packages via the Feature Tool and manually via Package Manager>Add package from tarball into Unity. First thing I noticed is that I can't use the samples, because I can't open the scenes. I get the message: It is not allowed to open a scene in a read-only package. The second thing I realized is that I could not work normally with the scripts. A lot of classes, types, methods where not highligted and I cant navigate to them/jump into them. Also the scripts where not shown in the solution explorer and you cant find them → because they are in the package folder and under assets.

My question is: Is this intentional? Are the scripts not meant to be worked with? I am also not at all concerned with modifying such scripts, but merely navigating through them to understand the big picture.

To Reproduce Steps to reproduce the behavior:

  1. Create new unity project
  2. Add WebRTC package by Feature Tool or manually.
  3. Try to open some scripts from webrtc or a scene from the sample package

What I already did Problem with scenes: I saw this post and did what this guy said, so it works for now. But I guess this is not the normal way?

Environment

djee-ms commented 3 years ago

First thing I noticed is that I can't use the samples, because I can't open the scenes. I get the message: It is not allowed to open a scene in a read-only package.

This is a Unity """feature""", nothing we can do about it. You can copy the scene to your project and open it from there.

The second thing I realized is that I could not work normally with the scripts. A lot of classes, types, methods where not highligted and I cant navigate to them/jump into them. Also the scripts where not shown in the solution explorer and you cant find them → because they are in the package folder and under assets.

If I understand your issue, that is also a Unity """feature""". See the Settings > External Tools > Generate all .csproj files option (docs).

Now that being said I thought Feature Tool was already making a local copy so that you can open the scene and modify the scripts. So it sounds like a Feature Tool bug. I'd first try with the latest version, as I know the tool is under active development and issues fixed all the time, and then @davidkline-ms can probably provide further help. Also this is the wrong place to ask about that tool, but I don't know about any right one unfortunately (David?).

Mt-Perazim commented 3 years ago

Thank you very much. That helped me! Scripts are now readable :)

If I understand your issue, that is also a Unity """feature""". See the Settings > External Tools > Generate all .csproj files option (docs).

I used the version: MRFT-1.0.2103 I read a post where someone said that you have to check the manifest.json under Packages and add there the dependencies. That should fix the problem. But the dependencies were already set right.

djee-ms commented 3 years ago

No that's a Unity settings, not Feature Tool.