microsoft / MixedReality-WebRTC

MixedReality-WebRTC is a collection of components to help mixed reality app developers integrate audio and video real-time communication into their application and improve their collaborative experience
https://microsoft.github.io/MixedReality-WebRTC/
MIT License
898 stars 277 forks source link

The document typo for C# tutorial (UWP) at "A custom signaling solution" session. #856

Open JamestsaiTW opened 2 years ago

JamestsaiTW commented 2 years ago

Describe the bug https://microsoft.github.io/MixedReality-WebRTC/manual/cs/helloworld-cs-signaling-uwp.html

Document typos.

To Reproduce Steps to reproduce the behavior:

At Step 4, code is:
private void Peer_LocalSdpReadytoSend(SdpMessage message) { var msg = NodeDssSignaler.FromSdpMessage(message); _signaler.SendMessageAsync(msg); } private void Peer_IceCandidateReadytoSend(IceCandidate iceCandidate) { var msg = NodeDssSignaler.FromIceCandidate(iceCandidate); _signaler.SendMessageAsync(msg); }

image

Expected behavior
It should be: private void Peer_LocalSdpReadytoSend(SdpMessage message) { var msg = NodeDssSignaler.Message.FromSdpMessage(message); _signaler.SendMessageAsync(msg); } private void Peer_IceCandidateReadytoSend(IceCandidate iceCandidate) { var msg = NodeDssSignaler.Message.FromIceCandidate(iceCandidate); _signaler.SendMessageAsync(msg); }

image