microsoft / MixedReality-WorldLockingTools-Unity

Unity tools to provide a stable coordinate system anchored to the physical world.
https://microsoft.github.io/MixedReality-WorldLockingTools-Unity/README.html
MIT License
188 stars 45 forks source link

[ISV] QR code under WLT snapping out of place after a loop closure #236

Closed srinjoym closed 2 years ago

srinjoym commented 2 years ago

We have observed an issue where a QR code under frozen space jumps to the correct place after a loop closure then immediately jumps to the incorrect place

fast-slow-still commented 2 years ago

I haven't been able to repro this, and from your description it sounds like very application specific problem. If I understand correctly, the Space Pin placed by the QR code does end up in the correct place, but the QR code diagnostic/UX element (not sure which), which is not influenced by the space pin system, first moves to the correct position (on the refit operation) and then gets moved to an incorrect position.

Obviously I can only guess here, since I haven't seen the code, but it sounds like something on the application side might be thinking that it is keeping the QR code visualization in place, but is failing to take into account the effect of the refit operation, and so is actually moving the QR code to an incorrect position.

I would recommend putting diagnostics on the Space Pin, which winds up in the correct place, and the QR code, which winds up in the wrong place, and seeing when their global positions diverge.