search

microsoft / MixedReality-WorldLockingTools-Unity

Unity tools to provide a stable coordinate system anchored to the physical world.
https://microsoft.github.io/MixedReality-WorldLockingTools-Unity/README.html
MIT License
188 stars 45 forks source link

Update WorldLocking.ASA to use ASA SDK v2.11.0 #237

Closed r01hee closed 2 years ago

r01hee commented 2 years ago

For Hololens2(UWP) build, Space Pin ASA restored to incorrect position on using ASA SDK older than v.2.11.0.

On updating ASA SDK to v.2.11.0, compile error has occurred. The cause of this was NativeAnchor changed from UnityARFoundationAnchorComponent to ARAnchor by updating ASA SDK v2.11.0.

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

SimonDarksideJ commented 2 years ago

Just found this, thanks @r01hee . Was scratching my head at the reference errors.

fast-slow-still commented 2 years ago

Hi @r01hee , could you open an issue on:

For Hololens2(UWP) build, Space Pin ASA restored to incorrect position on using ASA SDK older than v.2.11.0.

It would be great if you could identify the issue clearly, and provide enough information to reproduce it. The WLT+ASA sample is tested with ASA v2.09 and v2.10, and restores to the correct position on both of those. So I am probably not understanding correctly what you are saying. Thanks!

SimonDarksideJ commented 2 years ago

Hi @r01hee , could you open an issue on:

For Hololens2(UWP) build, Space Pin ASA restored to incorrect position on using ASA SDK older than v.2.11.0.

It would be great if you could identify the issue clearly, and provide enough information to reproduce it. The WLT+ASA sample is tested with ASA v2.09 and v2.10, and restores to the correct position on both of those. So I am probably not understanding correctly what you are saying. Thanks!

You would need to discuss the issue with the ASA team who moved to using the ARFoundation 'ARAnchor' implementation over the internal extension with the later updates, which improved anchor reliability. This issue isn't fixing that issue, the fix is a result of upgrading to the latest ASA SDK which this PR does.

fast-slow-still commented 2 years ago

Hi @r01hee , please note that my request still stands. Thanks!

r01hee commented 2 years ago

Hi @fast-slow-still , thank you for your advice. I have opened the issue to describe more information.

r01hee commented 2 years ago

Hello @SimonDarksideJ , thank you for your follow-ups.

fast-slow-still commented 2 years ago

Folded into PR #241

Many thanks for your contribution, it has been very valuable!