microsoft / MixedReality-WorldLockingTools-Unity

Unity tools to provide a stable coordinate system anchored to the physical world.
https://microsoft.github.io/MixedReality-WorldLockingTools-Unity/README.html
MIT License
188 stars 45 forks source link

Log warning in PluginNoop instead of Error to avoid breaking tests #254

Closed NoTuxNoBux closed 2 years ago

NoTuxNoBux commented 2 years ago

It seems more suitable to log this as warning, since the back end has already been selected (perhaps on purpose), so this may not be an error at all.

Additionally, logging errors will cause Unity scene tests to fail, as error logs are treated as test failure. This can be ignored by updating the test, but it could require updating every test (e.g. our scene contains the world locking tools and the noop backend immediately constructs when running in CI on a Linux Unity environment).

fast-slow-still commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 2 pipeline(s).