microsoft / MixedReality-WorldLockingTools-Unity

Unity tools to provide a stable coordinate system anchored to the physical world.
https://microsoft.github.io/MixedReality-WorldLockingTools-Unity/README.html
MIT License
188 stars 45 forks source link

WLT Samples with MRTK3 #320

Open Tolerm opened 1 year ago

Tolerm commented 1 year ago

I found something useful in WLT Sample, like SpacePinOrientableManipulation.cs and PinManipulator.cs, but when my MRTK3 project imported this package I noticed that its denpendencies are Mixed Reality Toolkit Foundation and Mixed Reality Toolkit Standard Assets, which are both MRTK2 basic packages in conflict with MRTK3 on GUID or other aspects.

Will WLT Samples support MRTK3 ? or new Samples with MRTK3 will build? Maybe I need write scripts with MRTK3 referring to current WLT Sample scripts with MRTK2, can someone tell me how to implement this migration?

Any help would be appreciated!

coltonix commented 11 months ago

Exact same issue here. Waiting for answers and solutions.

genereddick commented 11 months ago

https://github.com/Fuzzy-Door-Tech/WLT-MRTK3-Port

This is a port to MRTK 3 but also upgrades the Unity version. Not sure about upgrading the sample projects though.

coltonix commented 11 months ago

@genereddick Thank you for replying on such short notice! Do I just move the WLT-MRTK3-Port-main folder into my project and it just works? I'm currently using MRTK3 & Unity 2021.3.30LTS.

genereddick commented 11 months ago

The way we do it is to remove the WLT from the project, put our version in a local folder and then add a reference to it via the project manifest file.

But it might work by replacing the WLT in the projects assets folder.

genereddick commented 11 months ago

Note that our version references current versions of the AR Foundation stack... XROrigin etc, so would need to update those

coltonix commented 11 months ago

@genereddick Thank you I will try it. Can I ask what exactly to write in the dependencies? For example, will it work if I put "com.unity.RandomName": "file:/my_package_folder"? I am quite new to unity and I am not so sure how to correctly specify the part before the colon

By the way, do you happen to have made QR code tracking work with MRTK3 hopefully? Something like this here but with MRTK3

genereddick commented 11 months ago

the meta data is in package.json file at the root of the linked project, looks like:

https://github.com/Fuzzy-Door-Tech/WLT-MRTK3-Port/blob/main/package.json: { "name": "com.fuzzydoortech.worldlockingtools", "version": "1.0.0", "displayName": "World Locking Tools", "description": "Shared code across various projects", "unity": "2022.3", "unityRelease": "0f1", "documentationUrl": "", "changelogUrl": "", "licensesUrl": "", "dependencies": {

}, "keywords": [

],
"author": {
  "name": "Microsoft",
  "email": "info@fuzzydoortech.com",
  "url": "https://viewscreen.com"
},
"files": [
  "Scripts*",
  "package.json.meta"
]

}

really you can ignore or change all of it, but the name "com.fuzzydoortech.worldlockingtools" is what will show up in the package manifest

genereddick commented 11 months ago

I had QR codes working in original version but never checked / tested with MRTK 3

coltonix commented 10 months ago

The way we do it is to remove the WLT from the project, put our version in a local folder and then add a reference to it via the project manifest file.

But it might work by replacing the WLT in the projects assets folder.

A late update but it does work by just replacing the WLT in the projects assets folder :) Thank you for the port!

Another thing though, can I ask if you have made this WLT advanced sample repo to work with MRTK 3? If not, would you be able to share your ideas on how to make it work like you did with the WLT-MRTK3-Port, please? I kind of feel that the undelying logic to update them is the same

genereddick commented 9 months ago

Never tried with the sample projects


From: coltonix @.> Sent: Monday, December 4, 2023 11:26 AM To: microsoft/MixedReality-WorldLockingTools-Unity @.> Cc: Gene Reddick @.>; Mention @.> Subject: Re: [microsoft/MixedReality-WorldLockingTools-Unity] WLT Samples with MRTK3 (Issue #320)

The way we do it is to remove the WLT from the project, put our version in a local folder and then add a reference to it via the project manifest file.

But it might work by replacing the WLT in the projects assets folder.

A late update but it does work by just replacing the WLT in the projects assets folder :) Thank you for the port!

Another thing though, can I ask if you have made this WLT sample repohttps://github.com/microsoft/MixedReality-WorldLockingTools-Samples/tree/master to work with MRTK 3? If not, would you be able to share your ideas on how to make it work like you did with the WLT-MRTK3-Port, please? I kind of feel that the undelying logic to update them is the same

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/MixedReality-WorldLockingTools-Unity/issues/320#issuecomment-1839328388, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAH4MQIPGW5HEKNDNKGNMFDYHYPWHAVCNFSM6AAAAAA3QO77MOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGMZDQMZYHA. You are receiving this because you were mentioned.Message ID: @.***>