search

microsoft / MixedRealityCompanionKit

This is a MixedRealityToolkit style repository for code bits and components that may not run directly on Microsoft HoloLens or immersive headsets but instead pair with them to build experiences.
MIT License
591 stars 286 forks source link

Video recording is broken #309

Open joranmarcy opened 5 years ago

joranmarcy commented 5 years ago

Hi everyone,

I managed to make the spectator view work with Unity 2017.4.11f with the most up to date code from the master branch. The problem is that the mp4 file generated by the video record feature is corrupted.

Only the first second of the video is fine and then the image is stuck with some artifacts popping.

I tried to use an old version of the companion toolkit (1.5.7.0) and I don't have this issue.

Does anyone know what could be the problem ?

Thanks, Joran.

joranmarcy commented 5 years ago

Here is an example of the resulting video :

5_Video.zip

joranmarcy commented 5 years ago

Ok, I reverted my local master branch to this commit : https://github.com/Microsoft/MixedRealityCompanionKit/commit/3278d79a06dcfdf47c37f8db60542d89a654c8e3

Commit name : Restart the spatial mapping observer when new data is requested.

Now it is working.

joranmarcy commented 5 years ago

Several commits like : https://github.com/Microsoft/MixedRealityCompanionKit/commit/2a31bd443fc5cd2ac52380dab668fcf59651af43 change the video encoder class. The issue might be here.

joranmarcy commented 5 years ago

I confirm, https://github.com/Microsoft/MixedRealityCompanionKit/commit/2a31bd443fc5cd2ac52380dab668fcf59651af43 is the commit causing trouble with video recording.

chrisfromwork commented 5 years ago

@fieldsJacksonG any thoughts on what may be causing this issue?