search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

clipBoxSizeID does not exist anymore on ClippingBox #10379

Closed Damagae closed 9 months ago

Damagae commented 2 years ago

Describe the issue

clipBoxSizeID does not exist anymore or is no longer accessible on Microsoft.MixedReality.Toolkit.Utilities.ClippingBox, thus making Clipping Primitive - Advanced Usage tutorial obsolete.

Feature area

Since clipBoxSizeID is not accessible anymore, it is not possible to follow Clipping Primitive - Advanced Usage to create a SecondClippingBox, allowing a second level of clipping.

Existing doc link

Clipping Primitive - Advanced Usage

Additional context

I am using Unity 2020.3.20 and MRTK 2.7.2. I migrated a project from MRTK 2.4.0 to 2.7.2, so I don't know on which exact version the problem has appeared. I couldn't find a simple workaround for this issue, so for now I didn't manage to maintain secondary clipping boxes on my migrated project.

keveleigh commented 2 years ago

@Cameron-Micka Should we be pointing to a different property now?

keveleigh commented 2 years ago

Looks like that field was removed in https://github.com/microsoft/MixedRealityToolkit-Unity/pull/8842, but it's not immediately obvious to me how to migrate the above doc.

Cameron-Micka commented 2 years ago

Ah yes, this system has changed a bit since that doc was made. I can update the docs to give more up to date advice. Thanks!

vtieto commented 2 years ago

@Cameron-Micka, if you'd like, we can do a quick meeting and go over the changes needed here. Or, you can just submit a PR--whichever works best for you.

Cameron-Micka commented 2 years ago

Thank you for the offer @vtieto! It's been a while since I looked at this system so let me gauge how big the doc change would be, and I'll reach back out to you. 😊

IssueSyncBot commented 9 months ago

We appreciate your feedback and thank you for reporting this issue.

Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.

Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.

Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.

Thank you for your continued support of the Mixed Reality Toolkit!