microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Add URP Support to MRTK3 #11154

Closed AMollis closed 1 year ago

AMollis commented 1 year ago

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Describe the problem

MRTK2 provided tools to convert materials for URP, MRTK3 is missing these tools.

Describe the solution you'd like

These material/shader tools need to be ported to MRTK3 or shaders updated for URP.

Describe alternatives you've considered

Add shaders that support Standard Render Pipeline and URP

Additional context

Here's a screenshot of the MRTK2 tool that needs to be ported:

image

AMollis commented 1 year ago

This is not needed....

Unity added a way for shaders to automatically adjust to URP being enabled, which is the path MRGT took

SubShader for URP: https://github.com/microsoft/MixedReality-GraphicsTools-Unity/blob/bf06f3e72c6b9daac2f047809e07d86401f2d715/com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandard.shader#L145

SubShader for built-in: https://github.com/microsoft/MixedReality-GraphicsTools-Unity/blob/bf06f3e72c6b9daac2f047809e07d86401f2d715/com.microsoft.mrtk.graphicstools.unity/Runtime/Shaders/GraphicsToolsStandard.shader#L210