microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

Controller model materials are broken under URP #11165

Closed Zee2 closed 1 year ago

Zee2 commented 1 year ago

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Discussed in https://github.com/microsoft/MixedRealityToolkit-Unity/discussions/11162

Originally posted by **imjusthere** November 2, 2022 I used the MRTK3 demo project and updated MRTK3 to the newest versions to fix some teleportation bugs. Then when I imported the Universal Render Pipeline it broke some of the materials. The controllers are pink. I can't edit the prefab controllers it is using because it tells me the folder is read only. I changed the input folders to not be read only but it doesn't seem to make a difference to Unity. I was able to create my own controller prefabs and fix the textures but I don't see where to replace the original controller prefabs with my own. Any help would be greatly appreciated.
Zee2 commented 1 year ago

@RogPodge updates on this?

Zee2 commented 1 year ago

Is this a gltf importer oopsie or something we're going to have to fix on our end?

keveleigh commented 1 year ago

@imjusthere Are you referring to these prefab controllers?

image

I'm not able to repro in my quick test :/ can you please confirm:

  1. Which glTF importer are you using and which version?
  2. Which MRTK version are you using?
  3. Which Unity version are you using?
  4. Which URP version are you using?

I was using:

  1. https://github.com/atteneder/glTFast/tree/v4.9.1
  2. 3.0.0-pre.12
  3. Unity 2021.3.8f1
  4. URP 12.1.7

Thanks!

keveleigh commented 1 year ago

Aha! I went through the set up steps again and was able to repro this time. Digging in now...

image
keveleigh commented 1 year ago

Okay, after clicking "Reimport All"

image

the controller (as well as all the MRTK sample scene content) has been reloaded using URP:

image

Does "Reimport All" work for you @imjusthere?

imjusthere commented 1 year ago

I'm afraid I can't test it. The project isn't the same anymore. I had to redo it because of multiple GLF importers.

On Thu, Dec 8, 2022 at 12:55 PM Kurtis @.***> wrote:

Okay, after clicking "Reimport All"

[image: image] https://user-images.githubusercontent.com/3580640/206554248-44914ecc-3ccd-4445-b884-48cf9eda1140.png

the controller (as well as all the MRTK sample scene content) has been reloaded using URP:

[image: image] https://user-images.githubusercontent.com/3580640/206554499-72be9e8a-ebd7-4f33-8c39-12fb37230bb9.png

Does "Reimport All" work for you @imjusthere https://github.com/imjusthere?

— Reply to this email directly, view it on GitHub https://github.com/microsoft/MixedRealityToolkit-Unity/issues/11165#issuecomment-1343277681, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMVNFDABTCTQF5YVXKSYMTWMI4MXANCNFSM6AAAAAARVM25DE . You are receiving this because you were mentioned.Message ID: @.***>

keveleigh commented 1 year ago

I'm afraid I can't test it. The project isn't the same anymore. I had to redo it because of multiple GLF importers.

No worries! I'm going to go ahead and close this issue for now though, since I believe I was able to fix it with an asset reimport.