microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

When using simulated hands, and the `CanvasProxyInteractor` is disabled by the mode manager, `UGUIInputAdapterDraggable` nullrefs #11354

Closed Zee2 closed 1 year ago

Zee2 commented 1 year ago

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:


Describe the bug

When the mode manager disables CanvasProxyInteractor during input simulation (from #10838), UGUIInputAdapterDraggable starts NREing when dragged on by a mouse, because it doesn't check for the validity of the proxy interactor during the drag.

To reproduce

Bring up hand, move mouse cursor onto object with UGUIInputAdapterDraggable, drag mouse, observe NREs

Expected behavior

Should be nullchecked/no NREs

AMollis commented 1 year ago

@shaynie please verify fixed

shaynie commented 1 year ago

Verified fixed with input simulation in HandInteractionExamples scene