Closed stbertou closed 8 years ago
@stbertou this is a good idea but feels more like an example/sample type thing rather than a reusable component in the HoloToolkit.
I will keep this issue open so we can find a better story to host such examples. Will get back to you with some ideas.
Happy to add it as an example so ppl can just grab it if they need it. Up to you, I can also keep in our local repo, that's not a problem at all !
How about an explicit Examples folder, i.e. Assets/HoloToolkit/Examples/
Actually I don't think we need to have the Examples folder inside the Assets folder. This will unnecessarily increase the size of the Unity packages being produced using Assets.
Perhaps it should be a the root level.
If we pull them out, I don't think we'll be able to include them in the .unitypackage if we ever publish one. When importing unity packages, it's pretty easy to uncheck the whole Example folder and avoid importing it into one's project. I've seen lots of packages organized this way, and it's really nice to be able to add the examples when you're first learning a package.
Anyone checked the size of the package as it stands now?
I'm seeing 7.76 MB off of master right now. If we're worried this might explode in size, maybe we could do Assets/HoloToolkitExamples? At least then they'd be available directly in the project when pulling the repo, but could easily be excluded when building the unity package?
Now that we've got an examples folder - #128, do we believe this belongs there?
Happy to move it there, let me know what you think guys.
@stbertou we have a HoloToolkit-Examples folder now :)
ah ah yeah I've noticed ;-)
OK it's live now => https://github.com/Microsoft/HoloToolkit-Unity/pull/164
PR was merged.
Hey again
Another thing I would be keen to share..
I’ve implemented a Color picker that is HL friendly:
Anyway let me know if you want me to put another PR for that.