search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

GestureManipulator Test Scene is broken. #268

Closed StephenHodgson closed 7 years ago

StephenHodgson commented 7 years ago

Neither hand nor clicker will trigger the gesture manipulator.

darax commented 7 years ago

OnEnable() gets called before Start() in GestureManipulator. GestureManipulator then never registers for the callback events. Simple fix is to change Start() to Awake() in GestureManipulator. I could make this change, but it would be easier for me if I could keep my fork focused on spatial understanding.

Edit... I think you should probably take this one. :)

StephenHodgson commented 7 years ago

Haha, on top of it! Got a PR in already.

darax commented 7 years ago

:) I decided to figure out how to have more than one pull request in flight. I'll cancel the one I just submitted.

kotAPI commented 7 years ago

I was wondering the same about why it didn't work, is the repo updated?

StephenHodgson commented 7 years ago

Still waiting on PR https://github.com/Microsoft/HoloToolkit-Unity/pull/250 to be approved