search

microsoft / MixedRealityToolkit-Unity

This repository is for the legacy Mixed Reality Toolkit (MRTK) v2. For the latest version of the MRTK please visit https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity
https://aka.ms/mrtkdocs
MIT License
6k stars 2.12k forks source link

SurfacePlane doesn't function if placed in the editor. #34

Closed jwittner closed 8 years ago

jwittner commented 8 years ago

The plane is never assigned to and the surface data is never built.

angelaHillier commented 8 years ago

SurfacePlane is a helper object that works with the SurfaceMeshesToPlanes script. It is not a stand-alone component. The plane/surface data is filled in by SurfaceToPlanes after the planes have been generated.

angelaHillier commented 8 years ago

Be sure to check out the SpatialProcessing test scene in the HoloToolkit. This shows how SurfacePlane was originally intended to be used (as a referenced prefab on SurfaceMeshesToPlanes). If you do make SurfacePlane.cs a stand-alone component, then please make sure that you do not regress functionality of this test scene, since we rely on this in our spatial mapping course. Thanks!

angelaHillier commented 8 years ago

Looked at your change, and it's fine. Merged the code into main.

jwittner commented 8 years ago

Thanks for checking everything out. We're using the SpatialMeshesToPlanes pretty extensively, but testing was difficult without functionality in the editor. Glad the fixes were simple. =)

jwittner commented 8 years ago

Resolved by #35